linux-kernel - Re: [PATCH v3 1/1] media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b4f531d5eb1258709f8a584a4ef1ac14636a8db.camel@irl.hu>
Date: Thu, 20 Jun 2024 01:04:49 +0200
From: Gergo Koteles <soyer@....hu>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
  Mauro Carvalho Chehab <mchehab@...nel.org>,
  John Bauer <johnebgood@...uritylive.com>, linh.tp.vu@...il.com,
  linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] media: uvcvideo: UVC minimum relative
 pan/tilt/zoom speed fix.

Hi Ricardo,

Thanks for the review.

On Wed, 2024-06-19 at 08:15 +0200, Ricardo Ribalda wrote:
> 
> nit: The following would probably be more correct but less clear:
> 
> if  (is_relative_ptz_ctrl(xctrl->id))
>     min = -max;
> else
>     min = mapping->get(mapping, UVC_GET_MIN,...)
> 
> So up to you what do you/Laurent what is better ;)
> 

> 
I like this better. I'll send a v4.

Best regards,
Gergo Koteles