linux-kernel - Re: [PATCH 1/1] pinctrl: aspeed-g6: Add NCSI pin group config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4eb1830db13cc3aa8d23d2c6075f744c0b75bda1.camel@codeconstruct.com.au>
Date: Thu, 20 Jun 2024 09:15:48 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Potin Lai <potin.lai.pt@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Joel Stanley <joel@....id.au>,
  linux-aspeed@...ts.ozlabs.org, openbmc@...ts.ozlabs.org, 
 linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, Patrick Williams <patrick@...cx.xyz>, Cosmo
 Chou <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>
Subject: Re: [PATCH 1/1] pinctrl: aspeed-g6: Add NCSI pin group config

On Wed, 2024-06-19 at 19:24 +0800, Potin Lai wrote:
> On Mon, Jun 17, 2024 at 3:33 PM Andrew Jeffery
> <andrew@...econstruct.com.au> wrote:
> > 
> > On Thu, 2024-06-13 at 16:07 +0800, Potin Lai wrote:
> > > In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not
> > > needed on the management controller side.
> > > 
> > > To optimize pin usage, add new NCSI pin groupis that excludes RMIIXRCLKO,
> > > reducing the number of required pins.
> > 
> > Hmm, I'm not convinced this is specific to NCSI (and it's an
> > unfortunate mistake on my part), but we do need to call the groups
> > something different than RMII[34]. Did you have any other suggestions?
> > 
> I don't have better name for now.
> In ast2600 data sheet, it also mentioned "RMII" & "NCSI" together most
> of the time, is it ok to use "NCSI" as a new group name?

Perhaps we go with "NCSI", because the other thoughts I had are all
much less succinct.

Can you please add a note to the description in the binding that
discusses the difference between the RMII and NCSI groups?

Andrew