linux-kernel - Re: [PATCH] zorro: Use str_plural() in amiga_zorro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 09:09:24 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] zorro: Use str_plural() in amiga_zorro_probe()

Hi Jiapeng,

On Tue, Jun 18, 2024 at 9:32 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
> Use existing str_plural() function rather than duplicating its
> implementation.
>
> ./drivers/zorro/zorro.c:155:22-39: opportunity for str_plural(zorro_num_autocon).
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9350
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Thanks for your patch!

> --- a/drivers/zorro/zorro.c
> +++ b/drivers/zorro/zorro.c
> @@ -152,7 +152,7 @@ static int __init amiga_zorro_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, bus);
>
>         pr_info("Zorro: Probing AutoConfig expansion devices: %u device%s\n",
> -                zorro_num_autocon, zorro_num_autocon == 1 ? "" : "s");
> +                zorro_num_autocon, str_plural(zorro_num_autocon));

Missing #include <linux/string_choices.h>

I will fix that up while applying.

Please try to at least compile-test your patches.
Thanks!

>
>         /* First identify all devices ... */
>         for (i = 0; i < zorro_num_autocon; i++) {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds