linux-kernel - Re: [PATCH 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024061947-street-italics-0cdf@gregkh>
Date: Wed, 19 Jun 2024 10:12:51 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Jie Gan <quic_jiegan@...cinc.com>, coresight@...ts.linaro.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Konrad Dybcio <konradybcio@...il.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Mike Leach <mike.leach@...aro.org>, Rob Herring <robh@...nel.org>,
	Suzuki Poulouse <suzuki.poulose@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Jinlong Mao <quic_jinlmao@...cinc.com>,
	Song Chai <quic_songchai@...cinc.com>,
	Tao Zhang <quic_taozha@...cinc.com>,
	Tingwei Zhang <quic_tingweiz@...cinc.com>,
	Trilok Soni <quic_tsoni@...cinc.com>,
	Yuanfang Zhang <quic_yuanfang@...cinc.com>, quic_liuxin@...cinc.com,
	quic_sijiwu@...cinc.com, quic_xinlon@...cinc.com,
	quic_xueqnie@...cinc.com, quic_yanzl@...cinc.com,
	quic_yijiyang@...cinc.com, quic_yuanjiey@...cinc.com
Subject: Re: [PATCH 2/3] coresight: Add coresight slave register driver to
 support data filter function in sysfs mode

On Wed, Jun 19, 2024 at 09:55:25AM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/hwtracing/coresight/coresight-csr.c
> > @@ -0,0 +1,315 @@
> …
> > +static int __csr_set_etr_traceid(struct coresight_device *csdev,
> > +			uint32_t atid_offset, uint32_t traceid,
> > +			bool enable)
> > +{
> …
> > +	spin_lock_irqsave(&drvdata->spin_lock, flags);
> > +	CS_UNLOCK(drvdata->base);
> …
> > +	CS_LOCK(drvdata->base);
> > +	spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> > +	return 0;
> > +}
> …
> 
> Would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/spinlock.h#L574


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot