linux-kernel - Re: [PATCH] drm: Remove unused function rcar_cmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 10:24:34 +0100
From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, laurent.pinchart@...asonboard.com
Cc: airlied@...il.com, daniel@...ll.ch, dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm: Remove unused function rcar_cmm_write

Quoting Jiapeng Chong (2024-06-19 08:54:36)
> The function are defined in the rcar_cmm.c file, but not called
> elsewhere, so delete the unused function.
> 
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.

Indeed it's unused.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> index 26a2f5ad8ee5..883b960e9acc 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> @@ -32,11 +32,6 @@ struct rcar_cmm {
>         } lut;
>  };
>  
> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
> -{
> -       return ioread32(rcmm->base + reg);
> -}
> -
>  static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
>  {
>         iowrite32(data, rcmm->base + reg);
> -- 
> 2.20.1.7.g153144c
>