linux-kernel - Re: Current state of the sysctl constification effort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240619092531.ighb6pxh2ls4qjpu@joelS2.panther.com>
Date: Wed, 19 Jun 2024 11:25:31 +0200
From: Joel Granados <j.granados@...sung.com>
To: Thomas Weißschuh <thomas@...ch.de>
CC: Luis Chamberlain <mcgrof@...nel.org>, <linux-kernel@...r.kernel.org>,
	Kees Cook <keescook@...omium.org>, <martin.lau@...ux.dev>
Subject: Re: Current state of the sysctl constification effort

On Sat, Jun 15, 2024 at 10:18:48PM +0200, Thomas Weißschuh wrote:
> On 2024-06-10 10:10:36+0000, Joel Granados wrote:
> > On Fri, Jun 07, 2024 at 03:54:01PM +0200, Thomas Weißschuh wrote:
> > > On 2024-06-07 11:40:53+0000, Joel Granados wrote:
> > > > On Fri, May 31, 2024 at 12:50:32PM +0200, Thomas Weißschuh wrote:
> > ...
> > > > Is there anything left to do besides
> > > > what is being discussed in this mail, to start changing the ctl_tables
> > > > to `static const`?
> > > 
> > > The changes to the tables also need (as per [0] and [1]):
> > > 
> > > * sysctl: move internal interfaces to const struct ctl_table
> > > * sysctl: allow registration of const struct ctl_table
> > > 
> > > I think we do the handlers for v6.11, the rest of [0] and [1] for v6.12
> > > and then we can go through the rest of the trees ctl_tables.
> > 
> > LGTM. Once you send "sysctl: move internal interfaces to const struct ctl_table" and
> > "sysctl: allow registration of const struct ctl_table", I'll put them
> > into sysctl-testing and have them there until they can go into sysctl-next
> > (after the end of the next merge window). Please send both of them in one
> > series and remember to work on the "what" and the "why" for the commit
> > messages and cover letter.
> 
> IMO all of the remaining commits can go in as one series, as they all
> belong to the sysctl core
This sounds good to me. If everything is related to sysctl core, then it
belongs in one series.

> (I can leave out "sysctl: constify standard sysctl tables")
This also sounds good. You can push this through when you are actually
changing all the static struct ctl_table occurances

> 
> FYI recent changes to the sysctl core introduced another prerequisite
> for "sysctl: move internal interfaces to const struct ctl_table", which
> is "bpf: Constify ctl_table argument of filter function".
> 
> See https://git.kernel.org/pub/scm/linux/kernel/git/thomas.weissschuh/linux.git/ sysctl-constfy
I see it. This looks like something related to BPF [STORAGE & CGROUPS]
(cc: martin.lau@...ux.dev). We can push it ("bpf: Constify ctl_table
argument of filter function") through sysctl-next, if Martin is OK with
it. Otherwise you need to send a separate patch to bpf@...r.kernel.org.

Best

-- 

Joel Granados