linux-kernel - Re: [PATCH] s390/cio: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240619123255.4b1a6c6d.pasic@linux.ibm.com>
Date: Wed, 19 Jun 2024 12:32:55 +0200
From: Halil Pasic <pasic@...ux.ibm.com>
To: Eric Farman <farman@...ux.ibm.com>
Cc: Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Jeff Johnson
 <quic_jjohnson@...cinc.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger
 <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Matthew
 Rosato <mjrosato@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH] s390/cio: add missing MODULE_DESCRIPTION() macros

On Tue, 18 Jun 2024 16:11:33 -0400
Eric Farman <farman@...ux.ibm.com> wrote:

> > > +MODULE_DESCRIPTION("VFIO based Physical Subchannel device
> > > driver");  
> > 
> > Halil/Mathew/Eric,
> > Could you please comment on this ?  
> 
> That's what is in the prologue, and is fine.

Eric can you explain it to me why is the attribute "physical" appropriate
here? I did a quick grep for "Physical Subchannel" only turned up hits
in vfio-ccw.

My best guess is that "physical" was somehow intended to mean the
opposite of "virtual". But actually it does not matter if our underlying
subchannel is emulated or not, at least AFAIU.

Regards,
Halil