linux-kernel - Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <362fdc698ce87ea2a19f38a65a000cb37272f8bb.camel@mediatek.com>
Date: Wed, 19 Jun 2024 10:37:41 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and
 read/write page helper functions into mtk phy lib

On Wed, 2024-06-19 at 16:17 +0800, SkyLake.Huang wrote:
> On Tue, 2024-06-18 at 08:21 -0700, Jakub Kicinski wrote:
> >  	 
> > External email : Please do not click links or open attachments
> > until
> > you have verified the sender or the content.
> >  On Thu, 13 Jun 2024 18:40:20 +0800 Sky Huang wrote:
> > > This patch moves mtk-ge-soc.c's LED code into mtk phy lib. We
> > > can use those helper functions in mtk-ge.c as well. That is to
> > > say, we have almost the same HW LED controller design in
> > > mt7530/mt7531/mt7981/mt7988's Giga ethernet phy.
> > > 
> > > Also integrate read/write pages into one helper function. They
> > > are basically the same.
> > 
> > Could you please split this into multiple patches? maybe:
> >  - change the line wrapping
> >  - integrate read/write pages into one helper 
> >  - create mtk-phy-lib.c and mtk.h (pure code move)
> >  - add support for LEDs to the other SoC
> 
> Hi Jakub,
>   Mmm...Sorry. But is this really necessary? I already did similar
> things in v2. IMHO, current patchset is small enough for reviewing.
> You
> can easily tell that which parts come from original mediatek-ge.c &
> mediatek-ge-soc.c and which part is used for MT7988's mtk-2p5ge.c
> 
> BRs,
> Sky

Hi Jakub,
  After seeing Russell's comments and reviewing my patch again, I think
I got your points. I'll re-organize this patch in this way:
- create mtk-phy-lib.c & mtk.h and move LED helpers from mtk-ge-soc.c
- integrate read/write pages into one helper
- hook LED helper functions in mtk-ge.c
- Add MT7530 & MT7531's PHY ID macros
- Shrink mtk-ge-soc.c line wrapping to 80 characters

BRs,
Sky