linux-kernel - Re: [PATCH] net: usb: ax88179

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <597e6e88160ea0bbc67a0728a366597f@ipfire.org>
Date: Wed, 19 Jun 2024 12:37:15 +0200
From: Arne Fitzenreiter <arne_f@...ire.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, linux-usb@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Yongqin Liu <yongqin.liu@...aro.org>,
 Antje Miederhöfer <a.miederhoefer@....de>
Subject: Re: [PATCH] net: usb: ax88179_178a: improve reset check

Hello Jose Ignacio,

this patch fix my issues.

Best regards
Arne


Am 2024-06-17 12:28, schrieb Jose Ignacio Tornos Martinez:
> After ecf848eb934b ("net: usb: ax88179_178a: fix link status when link 
> is
> set to down/up") to not reset from usbnet_open after the reset from
> usbnet_probe at initialization stage to speed up this, some issues have
> been reported.
> 
> It seems to happen that if the initialization is slower, and some time
> passes between the probe operation and the open operation, the second 
> reset
> from open is necessary too to have the device working. The reason is 
> that
> if there is no activity with the phy, this is "disconnected".
> 
> In order to improve this, the solution is to detect when the phy is
> "disconnected", and we can use the phy status register for this. So we 
> will
> only reset the device from reset operation in this situation, that is, 
> only
> if necessary.
> 
> The same bahavior is happening when the device is stopped (link set to
> down) and later is restarted (link set to up), so if the phy keeps 
> working
> we only need to enable the mac again, but if enough time passes between 
> the
> device stop and restart, reset is necessary, and we can detect the
> situation checking the phy status register too.
> 
> cc: stable@...r.kernel.org # 6.6+
> Fixes: ecf848eb934b ("net: usb: ax88179_178a: fix link status when link 
> is set to down/up")
> Reported-by: Yongqin Liu <yongqin.liu@...aro.org>
> Reported-by: Antje Miederhöfer <a.miederhoefer@....de>
> Reported-by: Arne Fitzenreiter <arne_f@...ire.org>
> Tested-by: Yongqin Liu <yongqin.liu@...aro.org>
> Tested-by: Antje Miederhöfer <a.miederhoefer@....de>
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
> ---
>  drivers/net/usb/ax88179_178a.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/usb/ax88179_178a.c 
> b/drivers/net/usb/ax88179_178a.c
> index 51c295e1e823..c2fb736f78b2 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -174,7 +174,6 @@ struct ax88179_data {
>  	u32 wol_supported;
>  	u32 wolopts;
>  	u8 disconnecting;
> -	u8 initialized;
>  };
> 
>  struct ax88179_int_data {
> @@ -1678,12 +1677,21 @@ static int ax88179_reset(struct usbnet *dev)
> 
>  static int ax88179_net_reset(struct usbnet *dev)
>  {
> -	struct ax88179_data *ax179_data = dev->driver_priv;
> +	u16 tmp16;
> 
> -	if (ax179_data->initialized)
> +	ax88179_read_cmd(dev, AX_ACCESS_PHY, AX88179_PHY_ID, GMII_PHY_PHYSR,
> +			 2, &tmp16);
> +	if (tmp16) {
> +		ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
> +				 2, 2, &tmp16);
> +		if (!(tmp16 & AX_MEDIUM_RECEIVE_EN)) {
> +			tmp16 |= AX_MEDIUM_RECEIVE_EN;
> +			ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
> +					  2, 2, &tmp16);
> +		}
> +	} else {
>  		ax88179_reset(dev);
> -	else
> -		ax179_data->initialized = 1;
> +	}
> 
>  	return 0;
>  }