linux-kernel - Re: [PATCH] arm64: defconfig: Enable secure QFPROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 14:23:55 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mukesh Ojha <quic_mojha@...cinc.com>
Cc: Komal Bajaj <quic_kbajaj@...cinc.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] arm64: defconfig: Enable secure QFPROM driver

On 19/06/2024 14:10, Mukesh Ojha wrote:
> On Wed, Jun 19, 2024 at 01:08:48PM +0200, Krzysztof Kozlowski wrote:
>> On 19/06/2024 12:56, Komal Bajaj wrote:
>>> Enable the secure QFPROM driver which is used by QDU1000
>>
>> Qualcomm QDU1000. You are changing kernel-wide defconfig, not some
>> Qualcomm downstream stuff.
>>
>>> platform for reading the secure qfprom region to get the
>>> DDR channel configuration.
>>>
>>> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
>>> ---
>>>  arch/arm64/configs/defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 838b4466d6f6..c940437ae1b3 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -1575,6 +1575,7 @@ CONFIG_NVMEM_LAYERSCAPE_SFP=m
>>>  CONFIG_NVMEM_MESON_EFUSE=m
>>>  CONFIG_NVMEM_MTK_EFUSE=y
>>>  CONFIG_NVMEM_QCOM_QFPROM=y
>>> +CONFIG_NVMEM_QCOM_SEC_QFPROM=y
>>
>> Module
> 
> Should not this be inline with what CONFIG_NVMEM_QCOM_QFPROM is having ?
> Either both CONFIG_NVMEM_QCOM_QFPROM and CONFIG_NVMEM_QCOM_SEC_QFPROM
> should be m or both y

Why? There is no dependency in Kconfig.

Best regards,
Krzysztof