linux-kernel - Re: [PATCH net-next v2] wifi: mt76: un-embedd netdev from mt76

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 15:36:56 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: linux-wireless@...r.kernel.org,  davem@...emloft.net,
  edumazet@...gle.com,  pabeni@...hat.com,  Felix Fietkau <nbd@....name>,
  Lorenzo Bianconi <lorenzo@...nel.org>,  Ryder Lee
 <ryder.lee@...iatek.com>,  Shayne Chen <shayne.chen@...iatek.com>,  Sean
 Wang <sean.wang@...iatek.com>,  Matthias Brugger <matthias.bgg@...il.com>,
  AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
  netdev@...r.kernel.org,  horms@...nel.org,  kees@...nel.org,  Bo Jiao
 <Bo.Jiao@...iatek.com>,  Alexander Couzens <lynxis@...0.eu>,  Deren Wu
 <deren.wu@...iatek.com>,  Ming Yen Hsieh <mingyen.hsieh@...iatek.com>,
  Leon Yen <leon.yen@...iatek.com>,  Quan Zhou <quan.zhou@...iatek.com>,
  Ingo Rohloff <lundril@....de>,  Sujuan Chen <sujuan.chen@...iatek.com>,
  Peter Chiu <chui-hao.chiu@...iatek.com>,  StanleyYP Wang
 <StanleyYP.Wang@...iatek.com>,  Benjamin Lin
 <benjamin-jw.lin@...iatek.com>,  linux-kernel@...r.kernel.org (open
 list:ARM/Mediatek SoC support),  linux-arm-kernel@...ts.infradead.org
 (moderated list:ARM/Mediatek SoC support),
  linux-mediatek@...ts.infradead.org (moderated list:ARM/Mediatek SoC
 support)
Subject: Re: [PATCH net-next v2] wifi: mt76: un-embedd netdev from mt76_dev

Breno Leitao <leitao@...ian.org> writes:

> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_devices from struct mt76_dev by converting them
> into pointers, and allocating them dynamically. Use the leverage
> alloc_netdev_dummy() to allocate the net_device object at
> mt76_dma_init().
>
> The free of the device occurs at mt76_dma_cleanup().
>
> Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1]
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

As discussed in v1, feel free to take this to net-next to speed things
up:

Acked-by: Kalle Valo <kvalo@...nel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches