linux-kernel - Re: [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZnLVB1Cvy8PXhaMv@e133380.arm.com>
Date: Wed, 19 Jun 2024 13:54:31 +0100
From: Dave Martin <Dave.Martin@....com>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	James Morse <james.morse@....com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	shameerali.kolothum.thodi@...wei.com,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	carl@...amperecomputing.com, lcherian@...vell.com,
	bobo.shaobowang@...wei.com,
	"Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
	baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>,
	Peter Newman <peternewman@...gle.com>, dfustini@...libre.com,
	amitsinght@...vell.com, David Hildenbrand <david@...hat.com>,
	Rex Nie <rex.nie@...uarmicro.com>
Subject: Re: [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs

Hi,

On Tue, Jun 18, 2024 at 10:08:47AM -0700, Reinette Chatre wrote:
> Hi Dave,
> 
> On 6/18/24 9:16 AM, Dave Martin wrote:
> 
> > 
> > Either way, I don't think this impacts the tested-ness of this patch,
> > but please shout if you have concerns.
> > 
> 
> I agree. The submission stated that it was tested on x86
> "for the monitors-present case". When booting with
> "rdt=!cmt,!mbmtotal,!mbmlocal" (as I did in my test) resctrl
> is not able to discover monitoring support and it
> thus tested the "monitors _not_ present case".
> 
> Reinette

Ah, right.  I missed the significance of the options.

Thanks again!
---Dave
> 
>