linux-kernel - Re: [PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51c1faeb-c54d-4ee4-b913-50aed7a0909c@linux.intel.com>
Date: Wed, 19 Jun 2024 16:42:16 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Thomas Bonnefille <thomas.bonnefille@...tlin.com>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jisheng Zhang <jszhang@...nel.org>,
 Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>,
 Drew Fustini <dfustini@...storrent.com>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>,
 Conor Dooley <conor@...nel.org>
Cc: Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Miquèl Raynal <miquel.raynal@...tlin.com>,
 linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible
 thead,th1520-i2c

On 6/19/24 10:39 AM, Krzysztof Kozlowski wrote:
> On 19/06/2024 08:40, Jarkko Nikula wrote:
>> Hi
>>
>> On 6/18/24 10:42 AM, Thomas Bonnefille wrote:
>>> Add documentation for compatible string thead,th1520-i2c which can be
>>> used specifically for the TH1520 SoC.
>>>
>>> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
>>> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
>>> ---
>>>    Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>>> index d9293c57f573..60035a787e5c 100644
>>> --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>>> @@ -33,6 +33,10 @@ properties:
>>>              - const: snps,designware-i2c
>>>          - description: Baikal-T1 SoC System I2C controller
>>>            const: baikal,bt1-sys-i2c
>>> +      - description: T-HEAD TH1520 SoCs I2C controller
>>> +        items:
>>> +          - const: thead,th1520-i2c
>>> +          - const: snps,designware-i2c
>>>    
>>
>> Your comment below makes me thinking is this change needed? So is it
>> enough to specify "snps,designware-i2c" for the compatible string in
>> patch 2/3?
> 
> SoC specific compatible is always required (see writing bindings doc).
> 
Fair enough.

Reviewed-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>