linux-kernel - Re: [PATCH] fgraph: Use str_plural() in test_graph_storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 22:43:30 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: rostedt@...dmis.org, mhiramat@...nel.org,
 mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] fgraph: Use str_plural() in test_graph_storage_single()

On Tue, 18 Jun 2024 15:20:14 +0800
Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:

> Use existing str_plural() function rather than duplicating its
> implementation.
> 
> ./kernel/trace/trace_selftest.c:880:56-60: opportunity for str_plural(size).
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9349
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Thanks, this looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>


> ---
>  kernel/trace/trace_selftest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index adf0f436d84b..97f1e4bc47dc 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -877,7 +877,7 @@ static int __init test_graph_storage_single(struct fgraph_fixture *fixture)
>  	int ret;
>  
>  	pr_cont("PASSED\n");
> -	pr_info("Testing fgraph storage of %d byte%s: ", size, size > 1 ? "s" : "");
> +	pr_info("Testing fgraph storage of %d byte%s: ", size, str_plural(size));
>  
>  	ret = init_fgraph_fixture(fixture);
>  	if (ret && ret != -ENODEV) {
> -- 
> 2.20.1.7.g153144c
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>