linux-kernel - Re: [PATCH] HID: uclogic: avoid linking common code into multiple modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2406191629010.24940@cbobk.fhfr.pm>
Date: Wed, 19 Jun 2024 16:30:15 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: José Expósito <jose.exposito89@...il.com>
cc: Arnd Bergmann <arnd@...db.de>, Arnd Bergmann <arnd@...nel.org>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Rahul Rameshbabu <rrameshbabu@...dia.com>, 
    Fabio Baltieri <fabiobaltieri@...omium.org>, 
    Ivan Gorinov <linux-kernel@...imeter.info>, 
    Johannes Roith <johannes@...-linux.rocks>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: uclogic: avoid linking common code into multiple
 modules

On Fri, 14 Jun 2024, José Expósito wrote:

> > > Turns out that, since the last time I checked the KUnit docs,
> > > we have "EXPORT_SYMBOL_IF_KUNIT" available now.
> > >
> > > I think we can use it and your final patch, without the MODULE_*
> > > changes, could look like:
> > 
> > Looks good to me, can you send that with
> > 
> > Reported-by: Arnd Bergmann <arnd@...db.de>
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> I couldn't add the "Reported-by" tag because check-patch throws a
> warning if it is used without a "Closes" tag.

What?

Let's ignore (or even better fix) checkpatch, this is bad behavior.

> Other than that, I sent v2:
> https://lore.kernel.org/linux-input/20240614161935.230529-1-jose.exposito89@gmail.com/T/

I'll add Arnd's Reported-by: while applying that, credit must be given.

Thanks,

-- 
Jiri Kosina
SUSE Labs