linux-kernel - Re: [PATCH v2 1/2] HID: uclogic: Avoid linking common code into multiple modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2406191634011.24940@cbobk.fhfr.pm>
Date: Wed, 19 Jun 2024 16:34:15 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: José Expósito <jose.exposito89@...il.com>
cc: benjamin.tissoires@...hat.com, arnd@...db.de, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] HID: uclogic: Avoid linking common code into
 multiple modules

On Fri, 14 Jun 2024, José Expósito wrote:

> The hid-uclogic-params.o and hid-uclogic-rdesc.o files are linked
> into both the driver module and the unit test, which triggers a
> W=1 warning:
> 
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-rdesc.o is added to multiple modules: hid-uclogic hid-uclogic-test
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-params.o is added to multiple modules: hid-uclogic hid-uclogic-test
> 
> Avoids this by moving these two files into a separate module
> that is used by the driver and the unit test.
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>

I've added Reported-by: for Arnd and applied, thanks!

-- 
Jiri Kosina
SUSE Labs