linux-kernel - Re: [PATCH] net/mlx5: Lag, Remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240619073618.67ac1ca9@kernel.org>
Date: Wed, 19 Jun 2024 07:36:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] net/mlx5: Lag, Remove NULL check before dev_{put, hold}

On Wed, 19 Jun 2024 11:53:57 +0800 Jiapeng Chong wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL

s/of/or/

if you're touching this why not convert to netdev_hold() at the same
time?
-- 
pw-bot: au