linux-kernel - Re: [PATCH net-next v2 03/12] net: dsa: tag_sja1105: absorb logic for not overwriting precise info into dsa_8021q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620153903.pxagjityrvff7e7x@skbuf>
Date: Thu, 20 Jun 2024 18:39:03 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com, Russell King <linux@...linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 03/12] net: dsa: tag_sja1105: absorb logic
 for not overwriting precise info into dsa_8021q_rcv()

On Wed, Jun 19, 2024 at 10:52:09PM +0200, Pawel Dembicki wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> In both sja1105_rcv() and sja1110_rcv(), we may have precise source port
> information coming from parallel hardware mechanisms, in addition to the
> tag_8021q header.
> 
> Only sja1105_rcv() has extra logic to not overwrite that precise info
> with what's present in the VLAN tag. This is because sja1110_rcv() gets
> by, by having a reversed set of checks when assigning skb->dev. When the
> source port is imprecise (vbid >=1), source_port and switch_id will be
> set to zeroes by dsa_8021q_rcv(), which might be problematic. But by
> checking for vbid >= 1 first, sja1110_rcv() fends that off.
> 
> We would like to make more code common between sja1105_rcv() and
> sja1110_rcv(), and for that, we need to make sure that sja1110_rcv()
> also goes through the precise source port preservation logic.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Tested-by: Vladimir Oltean <olteanv@...il.com>