linux-kernel - Re: [RESEND PATCH 07/12] perf/x86/intel: Support Perfmon MSRs aliasing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cc9a843-a532-49b1-9d53-b1544ccb740e@linux.intel.com>
Date: Thu, 20 Jun 2024 12:17:42 -0400
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: mingo@...nel.org, acme@...nel.org, namhyung@...nel.org,
 irogers@...gle.com, adrian.hunter@...el.com,
 alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org,
 ak@...ux.intel.com, eranian@...gle.com
Subject: Re: [RESEND PATCH 07/12] perf/x86/intel: Support Perfmon MSRs
 aliasing



On 2024-06-20 4:02 a.m., Peter Zijlstra wrote:
> On Tue, Jun 18, 2024 at 08:10:39AM -0700, kan.liang@...ux.intel.com wrote:
>> @@ -6179,6 +6181,11 @@ static void intel_pmu_check_extra_regs(struct extra_reg *extra_regs)
>>  	}
>>  }
>>  
>> +static inline int intel_pmu_addr_offset(int index, bool eventsel)
>> +{
>> +	return MSR_IA32_PMC_STEP * index;
>> +}
> 
> This should have v6 in the name or somesuch... no?

Sure, I will add V6 in the name.

Thanks,
Kan
> 
>>  static const struct { enum hybrid_pmu_type id; char *name; } intel_hybrid_pmu_type_map[] __initconst = {
>>  	{ hybrid_small, "cpu_atom" },
>>  	{ hybrid_big, "cpu_core" },
>> @@ -7153,6 +7160,14 @@ __init int intel_pmu_init(void)
>>  		pr_cont("full-width counters, ");
>>  	}
>>  
>> +	/* Support V6+ MSR Aliasing */
>> +	if (x86_pmu.version >= 6) {
>> +		x86_pmu.perfctr = MSR_IA32_PMC_GP0_CTR;
>> +		x86_pmu.eventsel = MSR_IA32_PMC_GP0_CFG_A;
>> +		x86_pmu.fixedctr = MSR_IA32_PMC_FX0_CTR;
>> +		x86_pmu.addr_offset = intel_pmu_addr_offset;
>> +	}