linux-kernel - Re: [PATCH v3 2/2] KEYS: encrypted: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D24EWT5ESVET.2K1K93ONMJ1R5@kernel.org>
Date: Thu, 20 Jun 2024 03:19:33 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Jeff Johnson" <quic_jjohnson@...cinc.com>, "James Bottomley"
 <James.Bottomley@...senPartnership.com>, "Mimi Zohar"
 <zohar@...ux.ibm.com>, "David Howells" <dhowells@...hat.com>, "Paul Moore"
 <paul@...l-moore.com>, "James Morris" <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>
Cc: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
 <linux-security-module@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] KEYS: encrypted: add missing
 MODULE_DESCRIPTION()

On Fri Jun 7, 2024 at 4:47 AM EEST, Jeff Johnson wrote:
> During kbuild, with W=1, modpost will warn when a module doesn't have
> a MODULE_DESCRIPTION(). The encrypted-keys module does not have a
> MODULE_DESCRIPTION().  But currently, even with an allmodconfig
> configuration, this module is built-in, and as a result, kbuild does
> not currently warn about the missing MODULE_DESCRIPTION().
>
> However, just in case it is built as a module in the future, add the
> missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  security/keys/encrypted-keys/encrypted.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
> index 8af2136069d2..831cb84fd75a 100644
> --- a/security/keys/encrypted-keys/encrypted.c
> +++ b/security/keys/encrypted-keys/encrypted.c
> @@ -1040,4 +1040,5 @@ static void __exit cleanup_encrypted(void)
>  late_initcall(init_encrypted);
>  module_exit(cleanup_encrypted);
>  
> +MODULE_DESCRIPTION("Encrypted key type");
>  MODULE_LICENSE("GPL");

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko