linux-kernel - Re: [v2 PATCH] staging: vc04_services: vchiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 18:59:39 +0200
From: Stefan Wahren <wahrenst@....net>
To: Kieran Bingham <kieran.bingham@...asonboard.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Umang Jain <umang.jain@...asonboard.com>,
 linux-rpi-kernel@...ts.infradead.org
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.org>, detule
 <ogjoneski@...il.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE
 <linux-arm-kernel@...ts.infradead.org>,
 STAGING SUBSYSTEM <linux-staging@...ts.linux.dev>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [v2 PATCH] staging: vc04_services: vchiq_arm: Fix initialisation
 check

Hi Kieran,

Am 14.06.24 um 13:31 schrieb Kieran Bingham:
> Quoting Stefan Wahren (2024-06-14 12:00:38)
>> Hi Kieran,
>>
>> Am 14.06.24 um 12:43 schrieb Kieran Bingham:
>>> The vchiq_state used to be obtained through an accessor
>>> which would validate that the VCHIQ had been initialised
>>> correctly with the remote.
>>>
>>> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
>>> vchiq_state") the global state was moved to the vchiq_mgnt structures
>>> stored as a vchiq instance specific context. This conversion removed the
>>> helpers and instead replaced users of this helper with the assumption
>>> that the state is always available and the remote connected.
>>>
>>> Fix this broken assumption by re-introducing the logic that was lost
>>> during the conversion.
>>>
>>> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
>>> Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>
>>> ---
>>> v2:
>>>    - No change, just resend
>> what happen to my comments for the first version?
> Err ... i missed them ... let me go back and look!
sorry for pestering, but could you please send v3 of the fix? I want to
rebase my cleanup series on top of that, because bisecting vchiq is
currently no fun.

Thanks
Stefan
>
> --
> Kieran