linux-kernel - Re: [PATCH] wifi: iwlwifi: mvm: Fix __counted_by usage in cfg80211_wowlan_nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 12:08:04 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Kees Cook <kees@...nel.org>
Cc: benjamin.berg@...el.com, dmantipov@...dex.ru, gregory.greenman@...el.com,
 gustavoars@...nel.org, haim.dreyfuss@...el.com, johannes.berg@...el.com,
 kvalo@...nel.org, linux-hardening@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
 luciano.coelho@...el.com, miriam.rachel.korenblit@...el.com,
 shaul.triebitz@...el.com, yedidya.ben.shimol@...el.com
Subject: Re: [PATCH] wifi: iwlwifi: mvm: Fix __counted_by usage in
 cfg80211_wowlan_nd_*

On 6/20/24 12:02, Gustavo A. R. Silva wrote:
> 
>> My understanding is that 'match', is allocated by :
>>      match = kzalloc(struct_size(match, channels, n_channels), GFP_KERNEL);
>>
>> So match->n_channels is *0* when iwl_mvm_query_set_freqs() is called.
> 
> n_channels is updated in the line before calling kzalloc():
> 
> n_channels = iwl_mvm_query_num_match_chans(mvm, d3_data->nd_results, i);
> 
> match = kzalloc(struct_size(match, channels, n_channels), GFP_KERNEL);

then match->n_channels updated here:

  		if (!match)
  			goto out_report_nd;
+		match->n_channels = n_channels;

Sorry about the split response, finger failure ugghh

--
Gustavo