[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2564239.kdYZ1jHi8b@diego>
Date: Thu, 20 Jun 2024 20:42:42 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Sebastian Kropatsch <seb-dev@...l.de>
Cc: linux-rockchip@...ts.infradead.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: rockchip: Improve LEDs on NanoPi R6C/R6S
Am Mittwoch, 12. Juni 2024, 22:48:12 CEST schrieb Sebastian Kropatsch:
> Move led-3 node into NanoPi R6C/R6S's source files since they have
> different functionalities on each board: On the R6S this LED is used
> to signal LAN2 link up, while on the R6C this LED does not have a
> pre-defined purpose.
>
> In addition to that:
> - Remove deprecated label property
> - Add color and function properties
> - Add linux,default-trigger to trigger on Ethernet link
Again, please don't group unrelated changes together into one patch.
It makes things hard to read and hard to follow the changes.
>
> Signed-off-by: Sebastian Kropatsch <seb-dev@...l.de>
> ---
>
> DT validation doesn't like the 'linux,default-trigger = "stmmac-0:01:link"'
> properties, since "*:link" is not a valid value according to
> [Documentation/devicetree/bindings/leds/common.yaml]. These LEDs do
> have the specific purpose to show if an Ethernet link is up though.
> There is one LED for each Ethernet port and they are labeled WAN and
> LAN.
> Using the 'linux,default-trigger' like this does work perfectly fine
> with this solution. I could not find another way to achieve this. Please
> let me know if there is a better way.
> Maybe it would also be valid to add an entry to the DT bindings file to
> allow "*:link" as a value for 'linux,default-trigger'?
correct. If needed, things should be added to binding.
Heiko
Powered by blists - more mailing lists