linux-kernel - Re: [PATCH v9 3/7] coresight: core: Add provision for panic callbacks

Open Source and information security mailing list archives

Date: Thu, 20 Jun 2024 09:42:12 +0530
From: Linu Cherian <lcherian@...vell.com>
To: James Clark <james.clark@....com>
CC: <linux-arm-kernel@...ts.infradead.org>, <coresight@...ts.linaro.org>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <sgoutham@...vell.com>,
        <gcherian@...vell.com>, <suzuki.poulose@....com>,
        <mike.leach@...aro.org>
Subject: Re: [PATCH v9 3/7] coresight: core: Add provision for panic callbacks

On 2024-06-05 at 21:39:17, James Clark (james.clark@....com) wrote:
> 
> 
> On 05/06/2024 09:17, Linu Cherian wrote:
> > Panic callback handlers allows coresight device drivers to sync
> > relevant trace data and trace metadata to reserved memory
> > regions so that they can be retrieved later in the subsequent
> > boot or in the crashdump kernel.
> > 
> > Signed-off-by: Linu Cherian <lcherian@...vell.com>
> > Reviewed-by: James Clark <james.clark@....com>
> > ---
> > Changelog from v8:
> > Added Reviewed-by tag.
> > 
> >  drivers/hwtracing/coresight/coresight-core.c | 37 ++++++++++++++++++++
> >  include/linux/coresight.h                    | 12 +++++++
> >  2 files changed, 49 insertions(+)
> > 
> 
> [...]
> 
> >  static int __init coresight_init(void)
> >  {
> >  	int ret;
> > @@ -1377,6 +1408,10 @@ static int __init coresight_init(void)
> >  	if (ret)
> >  		goto exit_bus_unregister;
> >  
> > +	/* Register function to be called for panic */
> > +	ret = atomic_notifier_chain_register(&panic_notifier_list,
> > +					     &coresight_notifier);
> > +
> 
> ret isn't checked here

Ack.

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives