linux-kernel - Re: [PATCH 06/15] parisc: use correct compat recv/recvfrom syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a53789ee-9de1-49f9-93c2-58ba3fd47cae@gmx.de>
Date: Thu, 20 Jun 2024 22:36:39 +0200
From: Helge Deller <deller@....de>
To: Arnd Bergmann <arnd@...nel.org>, linux-arch@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: linux-parisc@...r.kernel.org
Subject: Re: [PATCH 06/15] parisc: use correct compat recv/recvfrom syscalls

On 6/20/24 18:23, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Johannes missed parisc back when he introduced the compat version
> of these syscalls, so receiving cmsg messages that require a compat
> conversion is still broken.
>
> Use the correct calls like the other architectures do.
>
> Fixes: 1dacc76d0014 ("net/compat/wext: send different messages to compat tasks")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Helge Deller <deller@....de>

Nice catch, Arnd!
I'll add a backport tag and take this patch through the parisc git tree.

Thank you!
Helge

> ---
>   arch/parisc/kernel/syscalls/syscall.tbl | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/syscalls/syscall.tbl b/arch/parisc/kernel/syscalls/syscall.tbl
> index b13c21373974..39e67fab7515 100644
> --- a/arch/parisc/kernel/syscalls/syscall.tbl
> +++ b/arch/parisc/kernel/syscalls/syscall.tbl
> @@ -108,7 +108,7 @@
>   95	common	fchown			sys_fchown
>   96	common	getpriority		sys_getpriority
>   97	common	setpriority		sys_setpriority
> -98	common	recv			sys_recv
> +98	common	recv			sys_recv			compat_sys_recv
>   99	common	statfs			sys_statfs			compat_sys_statfs
>   100	common	fstatfs			sys_fstatfs			compat_sys_fstatfs
>   101	common	stat64			sys_stat64
> @@ -135,7 +135,7 @@
>   120	common	clone			sys_clone_wrapper
>   121	common	setdomainname		sys_setdomainname
>   122	common	sendfile		sys_sendfile			compat_sys_sendfile
> -123	common	recvfrom		sys_recvfrom
> +123	common	recvfrom		sys_recvfrom			compat_sys_recvfrom
>   124	32	adjtimex		sys_adjtimex_time32
>   124	64	adjtimex		sys_adjtimex
>   125	common	mprotect		sys_mprotect