linux-kernel - [PATCH v2 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 22:38:30 +0200
From: Ferry Toth <ftoth@...londelft.nl>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ferry Toth <ftoth@...londelft.nl>,
	Hardik Gajjar <hgajjar@...adit-jv.com>,
	"Ricardo B. Marliere" <ricardo@...liere.net>,
	Kees Cook <kees@...nel.org>,
	Richard Acayan <mailingradian@...il.com>,
	Linyu Yuan <quic_linyyuan@...cinc.com>,
	Justin Stitt <justinstitt@...gle.com>,
	linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>,
	s.hauer@...gutronix.de,
	jonathanh@...dia.com,
	paul@...pouillou.net,
	quic_eserrao@...cinc.com,
	erosca@...adit-jv.com,
	regressions@...mhuis.info,
	Ferry Toth <fntoth@...il.com>,
	stable@...r.kernel.org
Subject: [PATCH v2 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment"

This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4.

Prerequisite revert for the reverting of the original commit f49449fbc21e.

Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment")
Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach")
Reported-by: Ferry Toth <fntoth@...il.com>
Cc: stable@...r.kernel.org
---
 drivers/usb/gadget/function/u_ether.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 11dd0b9e847f..aa0511c3a62c 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -1163,8 +1163,6 @@ struct net_device *gether_connect(struct gether *link)
 		if (netif_running(dev->net))
 			eth_start(dev, GFP_ATOMIC);
 
-		netif_device_attach(dev->net);
-
 	/* on error, disable any endpoints  */
 	} else {
 		(void) usb_ep_disable(link->out_ep);
-- 
2.43.0