linux-kernel - Re: [PATCH] kunit/usercopy: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 17:00:44 -0400
From: Rae Moar <rmoar@...gle.com>
To: Kees Cook <kees@...nel.org>
Cc: Shuah Khan <skhan@...uxfoundation.org>, Jeff Johnson <quic_jjohnson@...cinc.com>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	"Gustavo A. R. Silva" <gustavoars@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-hardening@...r.kernel.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit/usercopy: Add missing MODULE_DESCRIPTION()

On Wed, Jun 19, 2024 at 4:27 PM Kees Cook <kees@...nel.org> wrote:
>
> From: Jeff Johnson <quic_jjohnson@...cinc.com>
>
> Fix warning seen with:
>
> $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Kees Cook <kees@...nel.org>

Hi!

This looks good to me.

Reviewed-by: Rae Moar <rmoar@...gle.com>

Thanks!
-Rae

> ---
> At Jeff's reminder, I've split this out of:
> https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com/
> since the file got renamed.
> ---
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Cc: Jeff Johnson <quic_jjohnson@...cinc.com>
> Cc: Brendan Higgins <brendan.higgins@...ux.dev>
> Cc: David Gow <davidgow@...gle.com>
> Cc: Rae Moar <rmoar@...gle.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-kselftest@...r.kernel.org
> Cc: kunit-dev@...glegroups.com
> Cc: linux-hardening@...r.kernel.org
> Cc: linux-mm@...ck.org
> ---
>  lib/usercopy_kunit.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c
> index e819561a540d..77fa00a13df7 100644
> --- a/lib/usercopy_kunit.c
> +++ b/lib/usercopy_kunit.c
> @@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = {
>
>  kunit_test_suites(&usercopy_test_suite);
>  MODULE_AUTHOR("Kees Cook <kees@...nel.org>");
> +MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure");
>  MODULE_LICENSE("GPL");
> --
> 2.34.1
>