linux-kernel - Re: [PATCH v10 12/15] firmware: qcom: scm: add support for SHM bridge memory carveout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620160341297-0700.eberman@hu-eberman-lv.qualcomm.com>
Date: Thu, 20 Jun 2024 16:05:16 -0700
From: Elliot Berman <quic_eberman@...cinc.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konrad.dybcio@...aro.org>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Robert
 Marko" <robimarko@...il.com>,
        Das Srinagesh <quic_gurus@...cinc.com>,
        "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
        Maximilian Luz
	<luzmaximilian@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will
 Deacon" <will@...nel.org>,
        Srini Kandagatla <srinivas.kandagatla@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Alex Elder <elder@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <kernel@...cinc.com>
Subject: Re: [PATCH v10 12/15] firmware: qcom: scm: add support for SHM
 bridge memory carveout

On Mon, May 27, 2024 at 02:55:02PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Parse the "memory-region" property and - if present - use it to assign
> the dedicated reserved memory to the underlying DMA callbacks which will
> then allocate memory for the SCM calls from it.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Elliot Berman <quic_eberman@...cinc.com>

> ---
>  drivers/firmware/qcom/qcom_scm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index 94c34cde8179..c82957727650 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -23,6 +23,7 @@
>  #include <linux/of_address.h>
>  #include <linux/of_irq.h>
>  #include <linux/of_platform.h>
> +#include <linux/of_reserved_mem.h>
>  #include <linux/platform_device.h>
>  #include <linux/reset-controller.h>
>  #include <linux/sizes.h>
> @@ -1942,6 +1943,11 @@ static int qcom_scm_probe(struct platform_device *pdev)
>  	if (of_property_read_bool(pdev->dev.of_node, "qcom,sdi-enabled"))
>  		qcom_scm_disable_sdi();
>  
> +	ret = of_reserved_mem_device_init(__scm->dev);
> +	if (ret && ret != -ENODEV)
> +		return dev_err_probe(__scm->dev, ret,
> +				     "Failed to setup the reserved memory region for TZ mem\n");
> +
>  	ret = qcom_tzmem_enable(__scm->dev);
>  	if (ret)
>  		return dev_err_probe(__scm->dev, ret,
> 
> -- 
> 2.43.0
>