linux-kernel - Re: [PATCH v5 04/15] soc: qcom: ice: add hwkm support in ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef3ab301-563d-4939-9eb6-ec4c097ea07a@linaro.org>
Date: Thu, 20 Jun 2024 08:51:44 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Gaurav Kashyap (QUIC)" <quic_gaurkash@...cinc.com>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
 "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
 "andersson@...nel.org" <andersson@...nel.org>,
 "ebiggers@...gle.com" <ebiggers@...gle.com>,
 "srinivas.kandagatla" <srinivas.kandagatla@...aro.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
 kernel <kernel@...cinc.com>,
 "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "Om Prakash Singh (QUIC)" <quic_omprsing@...cinc.com>,
 "Bao D. Nguyen (QUIC)" <quic_nguyenb@...cinc.com>,
 "bartosz.golaszewski" <bartosz.golaszewski@...aro.org>,
 "konrad.dybcio@...aro.org" <konrad.dybcio@...aro.org>,
 "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
 "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
 "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
 "mani@...nel.org" <mani@...nel.org>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
 Prasad Sodagudi <psodagud@...cinc.com>, Sonal Gupta <sonalg@...cinc.com>
Subject: Re: [PATCH v5 04/15] soc: qcom: ice: add hwkm support in ice

On 20/06/2024 00:02, Gaurav Kashyap (QUIC) wrote:
> Hello Krzysztof
> 
> On 06/18/2024 11:17 PM PDT, Krzysztof Kozlowski wrote:
>> On 19/06/2024 00:08, Gaurav Kashyap (QUIC) wrote:
>>>>
>>>> You may perhaps only call qcom_scm_derive_sw_secret_available() for
>>>> some ICE versions.
>>>>
>>>> Neil
>>>
>>> The issue here is that for the same ICE version, based on the chipset,
>>> there might be different configurations.
>>
>> That's not what your DTS said. To remind: your DTS said that all SM8550 and
>> all SM8650 have it. Choice is obvious then: it's deducible from compatible.
>>
>> I still do not understand why your call cannot return you correct
>> "configuration".
>>
> 
> ICE version and chipsets are disjoint, meaning for the same ICE HW present in SM8650 vs SMxxxx target,
> SM8650 will have necessary TZ support, but SM8xxxx may not, that is the reason I was trying to indicate all SM8550 and
> SM8650 have the necessary TZ support. There might have been a miscommunication there.

No. Read your DTS again.

Best regards,
Krzysztof