linux-kernel - Re: [PATCH] rust: alloc: Fix unused import warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nSP8RcHuDmcPWAjjvYtyULi=g7tGcqOo8nKo2dN9evVw@mail.gmail.com>
Date: Thu, 20 Jun 2024 09:49:30 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: "Ethan D. Twardy" <ethan.twardy@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Danilo Krummrich <dakr@...hat.com>, 
	"open list:RUST" <rust-for-linux@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: alloc: Fix unused import warning

On Thu, Jun 20, 2024 at 4:11 AM Ethan D. Twardy <ethan.twardy@...il.com> wrote:
>
> core::ptr is only used in code that's not compiled during test, which
> causes rustc to emit the below warning while building the rusttest
> target. Add a conditional attribute to match conditions at the usage
> site.

We have an alternative fix (that avoids conditional compilation) for
this one in the `rust-fixes` branch that I am planning to send to
Linus this week.

    https://lore.kernel.org/r/20240519210735.587323-1-ojeda@kernel.org

If that one does not fix the issue for you, please let me know!

Thanks!

Cheers,
Miguel