[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a7317981-8690-4d45-81b6-cc6a63c459e0@collabora.com>
Date: Thu, 20 Jun 2024 10:01:18 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Conor Dooley <conor@...nel.org>
Cc: krzk+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
robh@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com,
jassisinghbrar@...il.com, garmin.chang@...iatek.com,
houlong.wei@...iatek.com, Jason-ch.Chen@...iatek.com, amergnat@...libre.com,
Elvis.Wang@...iatek.com, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
kernel@...labora.com
Subject: Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on
MT8188 GCE
Il 19/06/24 19:49, Conor Dooley ha scritto:
> On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
>> Add mediatek,mt8188-gce to the list of compatibles for which the
>> clock-names property is not required.
>
> Because, I assume, it has some internal clock? Why do either of these
> things have no clock? Doesn't the internal logic require one?
>
Because there's no gce0/gce1 clock, there's only an infracfg_AO clock that is
for one GCE instance, hence there's no need to require clock-names.
I can't remove the clock-names requirement from the older compatibles though,
because the (sorry about this word) driver (eh..) gets the clock by name for
the single GCE SoCs...
...and here comes a self-NACK for this commit, I have to fix the driver and
then stop requiring clock-names on all compatibles, instead of having this
ugly nonsense.
Self-note: gce0/gce1 clocks lookup was implemented in the driver but never
used and never added to the binding - luckily.
Sorry Conor, I just acknowledged that there's a better way of doing that.
Thank you for making me re-read this stuff, I'll send the proper changes
later today, driver change + binding change in a separate series.
As for the other two commits in this series, completely unrelated to GCE,
those are still fine, and are fixing dtbs_check warnings.
Cheers,
Angelo
>>
>> Fixes: f2b53c295620 ("dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> index cef9d7601398..55d4c34aa4b4 100644
>> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> @@ -62,7 +62,9 @@ allOf:
>> properties:
>> compatible:
>> contains:
>> - const: mediatek,mt8195-gce
>> + enum:
>> + - mediatek,mt8188-gce
>> + - mediatek,mt8195-gce
>> then:
>> required:
>> - clock-names
>> --
>> 2.45.2
>>
Powered by blists - more mailing lists