linux-kernel - Re: [PATCH] ACPI / amba: Drop unnecessary check for registered amba_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 09:38:18 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Youwan Wang <youwan@...china.com>
Cc: lpieralisi@...nel.org, guohanjun@...wei.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	lenb@...nel.org, rafael@...nel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] ACPI / amba: Drop unnecessary check for registered
 amba_dummy_clk

On Thu, Jun 20, 2024 at 08:59:30AM +0800, Youwan Wang wrote:
> amba_register_dummy_clk() is called only once from acpi_amba_init()
> and acpi_amba_init() itself is called once during the initialisation.
> amba_dummy_clk can't be initialised before this in any other code
> path and hence the check for already registered amba_dummy_clk is
> not necessary. Drop the same.
>

You are not reading my response correctly and fixing all the issues.

1. You had v3 and now this is again v1 ? Perhaps v4 ?
2. You missed to add my Acked-by which I gave to your v2
3. This is v4 and new reviewers of this patch have absolutely no idea
   what got changed from v1->v2->v3->v4. It is always good to add change
   log describing what changed across these versions
4. I asked you to add ARM64 maintainers as we would request them to pick
   this up via ARM64 tree.
	Catalin Marinas <catalin.marinas@....com
	Will Deacon <will@...nel.org>

I will ignore your patches if these are not fixed, I have told you same
thing twice now.

--
Regards,
Sudeep