linux-kernel - Re: [PATCH v3 13/41] iio: adc: meson_saradc: make use of regmap_clear_bits(), regmap_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 12:41:45 +0300
From: George Stark <gnstark@...utedevices.com>
To: Trevor Gamblin <tgamblin@...libre.com>
CC: <linux-iio@...r.kernel.org>, Jean-Baptiste Maneyrol
	<jmaneyrol@...ensense.com>, Crt Mori <cmo@...exis.com>, Fabio Estevam
	<festevam@...il.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, Scott Branden
	<sbranden@...adcom.com>, Ray Jui <rjui@...adcom.com>, Chen-Yu Tsai
	<wens@...e.org>, Shawn Guo <shawnguo@...nel.org>, Martin Blumenstingl
	<martin.blumenstingl@...glemail.com>, Sascha Hauer <s.hauer@...gutronix.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>, Neil Armstrong
	<neil.armstrong@...aro.org>, Jerome Brunet <jbrunet@...libre.com>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Linus Walleij
	<linus.walleij@...aro.org>, Nuno Sá <nuno.sa@...log.com>,
	Chunyan Zhang <zhang.lyra@...il.com>, Baolin Wang
	<baolin.wang@...ux.alibaba.com>, Saravanan Sekar <sravanhome@...il.com>,
	Dmitry Rokosov <ddrokosov@...rdevices.ru>, Lars-Peter Clausen
	<lars@...afoo.de>, Kevin Hilman <khilman@...libre.com>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	Cosmin Tanislav <cosmin.tanislav@...log.com>, <imx@...ts.linux.dev>,
	<linux-amlogic@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>, Uwe Kleine-König
	<u.kleine-koenig@...libre.com>, Jonathan Cameron <jic23@...nel.org>, Hans de
 Goede <hdegoede@...hat.com>, Orson Zhai <orsonzhai@...il.com>
Subject: Re: [PATCH v3 13/41] iio: adc: meson_saradc: make use of
 regmap_clear_bits(), regmap_set_bits()

On 6/17/24 16:49, Trevor Gamblin wrote:
> Instead of using regmap_update_bits() and passing the mask twice, use
> regmap_set_bits().
> 
> Instead of using regmap_update_bits() and passing val = 0, use
> regmap_clear_bits().
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>

Reviewed-by: George Stark <gnstark@...utedevices.com>

-- 
Best regards
George