linux-kernel - Re: [PATCH] leds: cros_ec: Implement review comments from Lee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 12:12:55 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-leds@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: cros_ec: Implement review comments from Lee

Hi Lee,

On 2024-06-20 10:31:14+0000, Lee Jones wrote:
> Definitely not seen a commit message like that before

I assumed that this patch would be squashed into the original commit.

My question in which form you wanted the changes should have included
"incremental series".

> > Implement review comments from Lee as requested in [0] for
> > "leds: Add ChromeOS EC driver".
> > 
> > Changes:
> > * Inline DRV_NAME string constant.
> > * Use dev_err() instead of dev_warn() to report errors.
> > * Rename cros_ec_led_probe_led() to cros_ec_led_probe_one().
> > * Make loop variable "int" where they belong.
> > * Move "Unknown LED" comment to where it belongs.
> > * Register trigger during _probe().
> > * Use module_platform_driver() and drop all the custom boilerplate.
> 
> If you're fixing many things, then I would expect to receive many
> patches.  One patch for functional change please.  If you can reasonably
> group fixes of similar elk, then please do.  However one patch that does
> a bunch of different things is a no-go from me, sorry.

Absolutely, if these changes are to end up as actual commits then they
need to look different.
I'll resend them as proper series.

> > [0] https://lore.kernel.org/lkml/20240614093445.GF3029315@google.com/T/#m8750abdef6a968ace765645189170814196c9ce9
> > 
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > ---
> >  drivers/leds/leds-cros_ec.c | 50 +++++++++++++--------------------------------
> >  1 file changed, 14 insertions(+), 36 deletions(-)

<snip>

Sorry for the confusion,
Thomas