lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d613221e-f026-400a-acec-921ef110ac29@kernel.org>
Date: Thu, 20 Jun 2024 12:57:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kanak Shilledar <kanakshilledar@...il.com>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vladimir Zapolskiy <vz@...ia.com>,
 linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt
 schema

On 20/06/2024 07:40, Kanak Shilledar wrote:
> Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx
> to newer DT schema. Created DT schema based on the .txt file
> which had `compatible`, `reg`, `interrupts`, `clocks`,
> `#address-cells` and `#size-cells` as required properties.
> 

Thank you for your patch. There is something to discuss/improve.


> +  clocks:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    description: the desired I2C bus clock frequency in Hz
> +    default: 100000
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - "#address-cells"
> +  - "#size-cells"

These should not be required, because you can have an enabled I2C
controller without children in DT.

> +


Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ