linux-kernel - Re: [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c42587a6-67e6-4f86-b865-9376bc4c0ed0@leemhuis.info>
Date: Thu, 20 Jun 2024 13:13:41 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Petr Vorel <pvorel@...e.cz>, linux-kernel@...r.kernel.org
Cc: Randy Dunlap <rdunlap@...radead.org>, Jonathan Corbet <corbet@....net>,
 Jiri Olsa <jolsa@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

On 18.06.24 11:06, Petr Vorel wrote:
> '==' is bashism, '=' needs to be used for comparison.
> With this fix script can work on systems where the default shell is
> dash, busybox ash or any other strictly POSIX compatible shell.
> 
> While at it, also improve:
> * remove "x" in the comparison (not needed for decades)
> * use $# for checking number of arguments
> * cleanup whitespace
> 
> Fixes: 4ab5a5d2a4a22 ("tools: add a kernel-chktaint to tools/debugging")
> Signed-off-by: Petr Vorel <pvorel@...e.cz>

Acked-by: Thorsten Leemhuis <linux@...mhuis.info>

Ciao, Thorsten