linux-kernel - Re: [PATCH v3 3/3] cxl/region: Simplify cxl_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620121517.00006e3e@Huawei.com>
Date: Thu, 20 Jun 2024 12:15:17 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Huang Ying <ying.huang@...el.com>
CC: Dan Williams <dan.j.williams@...el.com>, Dave Jiang
	<dave.jiang@...el.com>, <linux-cxl@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Alison Schofield
	<alison.schofield@...el.com>, Andrew Morton <akpm@...ux-foundation.org>,
	Bharata B Rao <bharata@....com>, Alistair Popple <apopple@...dia.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>, Davidlohr Bueso
	<dave@...olabs.net>, Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny
	<ira.weiny@...el.com>
Subject: Re: [PATCH v3 3/3] cxl/region: Simplify cxl_region_nid()

On Tue, 18 Jun 2024 16:46:39 +0800
Huang Ying <ying.huang@...el.com> wrote:

> The node ID of the region can be gotten via resource start address
> directly.  This simplifies the implementation of cxl_region_nid().
> 
> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
> Suggested-by: Alison Schofield <alison.schofield@...el.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Bharata B Rao <bharata@....com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>
> Cc: Davidlohr Bueso <dave@...olabs.net>
> Cc: Vishal Verma <vishal.l.verma@...el.com>
> Cc: Ira Weiny <ira.weiny@...el.com>
> ---
>  drivers/cxl/core/region.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index dc15ceba7ab7..605efe3562c6 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2309,15 +2309,13 @@ static bool cxl_region_update_coordinates(struct cxl_region *cxlr, int nid)
>  static int cxl_region_nid(struct cxl_region *cxlr)
>  {
>  	struct cxl_region_params *p = &cxlr->params;
> -	struct cxl_endpoint_decoder *cxled;
> -	struct cxl_decoder *cxld;
> +	struct resource *res;
>  
>  	guard(rwsem_read)(&cxl_region_rwsem);
> -	cxled = p->targets[0];
> -	if (!cxled)
> +        res = p->res;

Odd indent - I think spaces rather than tab.  Otherwise seems reasonable.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>


> +	if (!res)
>  		return NUMA_NO_NODE;
> -	cxld = &cxled->cxld;
> -	return phys_to_target_node(cxld->hpa_range.start);
> +	return phys_to_target_node(res->start);
>  }
>  
>  static int cxl_region_perf_attrs_callback(struct notifier_block *nb,