linux-kernel - Re: [PATCH net-next v2 10/12] net: dsa: prepare 'dsa_tag_8021q_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620123202.ygpoflgzqq5mipvz@skbuf>
Date: Thu, 20 Jun 2024 15:32:02 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com, Russell King <linux@...linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 10/12] net: dsa: prepare
 'dsa_tag_8021q_bridge_join' for standalone use

On Wed, Jun 19, 2024 at 10:52:16PM +0200, Pawel Dembicki wrote:
> The 'dsa_tag_8021q_bridge_join' could be used as a generic implementation
> of the 'ds->ops->port_bridge_join()' function. However, it is necessary
> to synchronize their arguments.
> 
> This patch also moves the 'tx_fwd_offload' flag configuration line into
> 'dsa_tag_8021q_bridge_join' body. Currently, every (sja1105) driver sets
> it, and the future vsc73xx implementation will also need it for
> simplification.
> 
> Suggested-by: Vladimir Oltean <olteanv@...il.com>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>