linux-kernel - Re: [PATCH v1 2/7] dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d9ad411-c76c-4d06-b8b8-6ca6bc4916a6@kernel.org>
Date: Thu, 20 Jun 2024 15:28:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org,
 angelogioacchino.delregno@...labora.com, andersson@...nel.org,
 konrad.dybcio@...aro.org, mturquette@...libre.com, sboyd@...nel.org,
 ulf.hansson@...aro.org, quic_sibis@...cinc.com, quic_rjendra@...cinc.com,
 luca@...tu.xyz, abel.vesa@...aro.org, quic_rohiagar@...cinc.com,
 danila@...xyga.com, otto.pflueger@...cue.de, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 2/7] dt-bindings: soc: qcom: cpr3: Add bindings for
 IPQ9574

On 20/06/2024 10:14, Varadarajan Narayanan wrote:
> Add the bindings for the IPQ9574 CPR3 driver to the documentation.
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
>  .../bindings/soc/qcom/qcom,cpr3.yaml          | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> index acf2e294866b..d5e02505c863 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> @@ -24,6 +24,7 @@ properties:
>        - const: qcom,cpr4
>        - items:
>            - enum:
> +              - qcom,ipq9574-cprh
>                - qcom,msm8998-cprh
>                - qcom,sdm630-cprh
>            - const: qcom,cprh
> @@ -52,9 +53,11 @@ properties:
>  
>    nvmem-cells:
>      description: Cells containing the fuse corners and revision data
> +    minItems: 17
>      maxItems: 32
>  
>    nvmem-cell-names:
> +    minItems: 17
>      maxItems: 32
>  
>    operating-points-v2: true
> @@ -74,6 +77,35 @@ required:
>  additionalProperties: false
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq9574-cprh
> +    then:
> +      properties:
> +

No need for blank line.

Constrain nvmem-cells. Also constrain the other variant.



Best regards,
Krzysztof