linux-kernel - Re: [RFC v1 1/3] mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620-sabbath-ambulance-b8764fb386e9@spud>
Date: Thu, 20 Jun 2024 15:12:16 +0100
From: Conor Dooley <conor@...nel.org>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: linux-mmc@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>,
	cyril.jean@...rochip.com, Mark Brown <broonie@...nel.org>,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	linux-spi@...r.kernel.org
Subject: Re: [RFC v1 1/3] mmc: mmc_spi: allow for spi controllers incapable
 of getting as low as 400k

On Thu, Jun 20, 2024 at 02:50:15PM +0200, Ulf Hansson wrote:
> On Wed, 12 Jun 2024 at 17:48, Conor Dooley <conor@...nel.org> wrote:
> >
> > From: Conor Dooley <conor.dooley@...rochip.com>
> >
> > Some controllers may not be able to reach a bus clock as low as 400 KHz
> > due to a lack of sufficient divisors. In these cases, the SD card slot
> > becomes non-functional as Linux continuously attempts to set the bus
> > clock to 400 KHz. If the controller is incapable of getting that low,
> > set its minimum frequency instead. While this may eliminate some SD
> > cards, it allows those capable of operating at the controller's minimum
> > frequency to be used.
> >
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Looks reasonable to me. I assume you intend to send a non-RFC for
> this, that I can pick up?

I do intend doing that. How soon depends on whether or not you are
willing to take it on its own, or require it to come in a series with
the spi driver changes.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)