linux-kernel - Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: Define a max count for "pinctrl-single,gpio-range"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240621133636.wfy3ucf2qkcqphdf@lantern>
Date: Fri, 21 Jun 2024 08:36:36 -0500
From: Nishanth Menon <nm@...com>
To: Andrew Davis <afd@...com>, Linus Walleij <linus.walleij@...aro.org>
CC: "Rob Herring (Arm)" <robh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Conor
 Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>, <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Tony
 Lindgren <tony@...mide.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: Define a max count
 for "pinctrl-single,gpio-range"

On 11:19-20240619, Andrew Davis wrote:
[...]

> 
> This binding is a bit of a mess, the phandle is always a pointer to
> a node with the cells length hard-coded to 3. This looks to have been done
> to allow the driver to use the function "of_parse_phandle_with_args" which
> needs a property name for to find the cell count. But that makes no sense
> as the count is always 3, the driver cannot accept any other value. The
> driver should have just looped of_get_property() 3 times but wanted to
> use the helper. So a silly driver mistake has turned into a binding issue.
> 
> We should drop the "pinctrl-single,gpio-range" from the binding and
> fix the driver.

Linus W: pinctrl-single,gpio-range -> any thoughts here? I think it is a
valid (if a bit too flexible design looking at the existing users who
just use a single mux value mapping for all modes)

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D