linux-kernel - Re: [PATCH 2/3] iio: accel: add ADXL380 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 10:11:41 +0800
From: kernel test robot <lkp@...el.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Ramona Gradinariu <ramona.gradinariu@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Jun Yan <jerrysteve1101@...il.com>,
	Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Mehdi Djait <mehdi.djait.k@...il.com>,
	Mario Limonciello <mario.limonciello@....com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 2/3] iio: accel: add ADXL380 driver

Hi Antoniu,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.10-rc4 next-20240620]
[cannot apply to jic23-iio/togreg]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Antoniu-Miclaus/iio-accel-add-ADXL380-driver/20240618-194141
base:   linus/master
patch link:    https://lore.kernel.org/r/20240618105150.38141-2-antoniu.miclaus%40analog.com
patch subject: [PATCH 2/3] iio: accel: add ADXL380 driver
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240621/202406210959.gSwDq0Ql-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240621/202406210959.gSwDq0Ql-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406210959.gSwDq0Ql-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/iio/accel/adxl380.c: In function '_adxl380_config_irq':
>> drivers/iio/accel/adxl380.c:1764:16: error: implicit declaration of function 'irq_get_irq_data'; did you mean 'irq_set_irq_wake'? [-Werror=implicit-function-declaration]
    1764 |         desc = irq_get_irq_data(st->irq);
         |                ^~~~~~~~~~~~~~~~
         |                irq_set_irq_wake
>> drivers/iio/accel/adxl380.c:1764:14: warning: assignment to 'struct irq_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1764 |         desc = irq_get_irq_data(st->irq);
         |              ^
>> drivers/iio/accel/adxl380.c:1768:20: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
    1768 |         irq_type = irqd_get_trigger_type(desc);
         |                    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/accel/adxl380.c:1769:25: error: 'IRQ_TYPE_LEVEL_HIGH' undeclared (first use in this function)
    1769 |         if (irq_type == IRQ_TYPE_LEVEL_HIGH) {
         |                         ^~~~~~~~~~~~~~~~~~~
   drivers/iio/accel/adxl380.c:1769:25: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/iio/accel/adxl380.c:1772:32: error: 'IRQ_TYPE_LEVEL_LOW' undeclared (first use in this function)
    1772 |         } else if (irq_type == IRQ_TYPE_LEVEL_LOW) {
         |                                ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +1764 drivers/iio/accel/adxl380.c

  1754	
  1755	static int _adxl380_config_irq(struct iio_dev *indio_dev)
  1756	{
  1757		int ret;
  1758		struct irq_data *desc;
  1759		unsigned long irq_flag;
  1760		u32 irq_type;
  1761		u8 polarity;
  1762		struct adxl380_state *st = iio_priv(indio_dev);
  1763	
> 1764		desc = irq_get_irq_data(st->irq);
  1765		if (!desc)
  1766			return dev_err_probe(st->dev, -EINVAL, "Could not find IRQ %d\n", st->irq);
  1767	
> 1768		irq_type = irqd_get_trigger_type(desc);
> 1769		if (irq_type == IRQ_TYPE_LEVEL_HIGH) {
  1770			polarity = 0;
  1771			irq_flag = IRQF_TRIGGER_HIGH;
> 1772		} else if (irq_type == IRQ_TYPE_LEVEL_LOW) {
  1773			polarity = 1;
  1774			irq_flag = IRQF_TRIGGER_LOW;
  1775		} else {
  1776			return dev_err_probe(st->dev, -EINVAL, "Invalid interrupt type 0x%x specified\n",
  1777				irq_type);
  1778		}
  1779	
  1780		ret = regmap_update_bits(st->regmap, ADXL380_INT0,
  1781					 ADXL380_INT0_POL_MSK,
  1782					 FIELD_PREP(ADXL380_INT0_POL_MSK, polarity));
  1783		if (ret)
  1784			return ret;
  1785	
  1786		return devm_request_threaded_irq(st->dev, st->irq, NULL,
  1787						 adxl380_irq_handler,
  1788						 IRQF_ONESHOT | irq_flag,
  1789						 indio_dev->name, indio_dev);
  1790	}
  1791	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki