linux-kernel - Re: [PATCH 1/4] x86/of: Return consistent error type from x86_of_pci_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240621141507.GHZnWK6-r6XEH2a9CR@fat_crate.local>
Date: Fri, 21 Jun 2024 16:15:07 +0200
From: Borislav Petkov <bp@...en8.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/4] x86/of: Return consistent error type from
 x86_of_pci_irq_enable()

On Mon, May 27, 2024 at 03:55:35PM +0300, Ilpo Järvinen wrote:
> x86_of_pci_irq_enable() returns PCIBIOS_* code received from
> pci_read_config_byte() directly and also -EINVAL which are not
> compatible error types. x86_of_pci_irq_enable() is used as
> (*pcibios_enable_irq) function which should not return PCIBIOS_* codes.
> 
> Convert the PCIBIOS_* return code from pci_read_config_byte() into
> normal errno using pcibios_err_to_errno().
> 
> Fixes: 96e0a0797eba ("x86: dtb: Add support for PCI devices backed by dtb nodes")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Cc: stable@...r.kernel.org

Any particular reason why this is CC:stable?

I'd say unless you're fixing a specific failure, this should go the normal
route to 6.11...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette