linux-kernel - Re: [PATCH v3 2/3] spi: dt-bindings: fsl-dspi: Convert to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 17:47:37 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH v3 2/3] spi: dt-bindings: fsl-dspi: Convert to yaml format

On Fri, Jun 21, 2024 at 10:39:33AM -0400, Frank Li wrote:
> On Fri, Jun 21, 2024 at 03:42:11PM +0300, Vladimir Oltean wrote:
> > > Use part of Vladimir Oltean's work at
> > > https://lore.kernel.org/linux-spi/20221111224651.577729-1-vladimir.oltean@nxp.com/
> > 
> > Hm, you took part of that but gave no attribution? The portion below ---
> > is also discarded when the patch is applied, so even the link is lost,
> > FYI.
> 
> I am not sure what should be added in comments? 
> 
> Ref part of Vladimir Oltean's work at https:// ... (I am not sure if allow
> http link).
>  
> Or coworked-with Vladimir Oltean ...
> Or use seperated patch for your part.
> 
> What do you like?
> 
> Frank

Well, it depends on how much from that work you end up taking.
I would recommend taking all of it :) and completing the unfinalized
review feedback with your work, plus some additions like the standard
CS timing parameters. Then, you could keep that sign off chain and add
yours at the bottom. At least that was my approach when I tried to
continue Kuldeep's work.

If you take a very small portion, I guess you could at least move the
link inside the portion of the commit message that remains visible in
the commit log.

And for a significant portion, Documentation/process/submitting-patches.rst
says you could add Co-developed-by + Signed-off-by, followed by your
sign off.