linux-kernel - Re: [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202406211503118dfe2df1@mail.local>
Date: Fri, 21 Jun 2024 17:03:11 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: Sean Anderson <sean.anderson@...o.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Joy Chakraborty <joychakr@...gle.com>, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on
 read

On 21/06/2024 07:23:24+0100, Srinivas Kandagatla wrote:
> 
> On Thu, 13 Jun 2024 12:07:50 +0000, Joy Chakraborty wrote:
> > Read callbacks registered with nvmem core expect 0 to be returned on
> > success and a negative value to be returned on failure.
> > 
> > abx80x_nvmem_xfer() on read calls i2c_smbus_read_i2c_block_data() which
> > returns the number of bytes read on success as per its api description,
> > this return value is handled as an error and returned to nvmem even on
> > success.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] rtc: abx80x: Fix return value of nvmem callback on read
>       commit: 126b2b4ec0f471d46117ca31b99cd76b1eee48d8
> 

Please drop it from your tree, I'm going to handle the rtc related
patches...

> Best regards,
> -- 
> Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com