linux-kernel - Re: [PATCH V2] hippi: fix possible buffer overflow caused by bad DMA value in rr_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240621083445.34d805d2@kernel.org>
Date: Fri, 21 Jun 2024 08:34:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sunil Kovvuri Goutham <sgoutham@...vell.com>
Cc: Huai-Yuan Liu <qq810974084@...il.com>, "jes@...ined-monkey.org"
 <jes@...ined-monkey.org>, "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "linux-hippi@...site.dk" <linux-hippi@...site.dk>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "baijiaju1990@...il.com" <baijiaju1990@...il.com>
Subject: Re: [PATCH V2] hippi: fix possible buffer overflow caused by bad
 DMA value in rr_start_xmit()

On Fri, 21 Jun 2024 05:11:41 +0000 Sunil Kovvuri Goutham wrote:
> >+	if (index >= TX_RING_ENTRIES) {
> >+		netdev_err(dev, "invalid index value %02x\n", index);  
> 
> Much better would be to use netif_msg_tx_err which can be
> enabled/disabled instead of dumping on console, which would be
> annoying if there are many errors.

Doesn't it require ethtool to be changed tho? This driver doesn't have
any ethtool ops AFAICT. I'd go for netdev_err_once().

But more importantly, I think you should stop the queue before
returning BUSY.