linux-kernel - Re: [PATCH 1/2] genirq/irq_sim: add a notifier for irqchip events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk3unw33.ffs@tglx>
Date: Fri, 21 Jun 2024 17:40:00 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij
 <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/2] genirq/irq_sim: add a notifier for irqchip events

On Wed, Jun 12 2024 at 13:52, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Currently users of the interrupt simulator don't have any way of being
> notified about interrupts from the simulated domain being requested or
> released. This causes a problem for one of the users - the GPIO
> simulator - which is unable to lock the pins as interrupts.
>
> Add a blocking notifier and provide interfaces to register with it, then
> use it to notify users of the domain about interrupts being requested
> and released while also leaving space for future extensions.

Why a notifier?

There is only one usage site per simulator domain. So there is no reason
to have a notifier with handwaving about future extensions.

The right thing to do is:

typedef void (*irq_sim_cb_t)(irq_hw_number_t hwirq, bool request, void *data)

struct irq_domain *irq_domain_create_sim(struct fwnode_handle *fwnode,
					 unsigned int num_irqs,
                                         irq_sim_cb_t *cb, void *cb_data);

You get the idea, right?

Thanks,

        tglx