[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0fc48134-b1c8-f46a-0490-10b7c724a871@amd.com>
Date: Fri, 21 Jun 2024 10:47:32 -0500
From: "Moger, Babu" <bmoger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, babu.moger@....com,
corbet@....net, fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com,
bp@...en8.de, dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, paulmck@...nel.org, rdunlap@...radead.org,
tj@...nel.org, peterz@...radead.org, yanjiewtw@...il.com,
kim.phillips@....com, lukas.bulwahn@...il.com, seanjc@...gle.com,
jmattson@...gle.com, leitao@...ian.org, jpoimboe@...nel.org,
rick.p.edgecombe@...el.com, kirill.shutemov@...ux.intel.com,
jithu.joseph@...el.com, kai.huang@...el.com, kan.liang@...ux.intel.com,
daniel.sneddon@...ux.intel.com, pbonzini@...hat.com, sandipan.das@....com,
ilpo.jarvinen@...ux.intel.com, peternewman@...gle.com,
maciej.wieczor-retman@...el.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, eranian@...gle.com, james.morse@....com
Subject: Re: [PATCH v4 08/19] x86/resctrl: Introduce the interface to display
monitor mode
On 6/20/2024 5:05 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 6/19/24 9:25 AM, Moger, Babu wrote:
>> On 6/13/24 20:40, Reinette Chatre wrote:
>>> On 5/24/24 5:23 AM, Babu Moger wrote:
>
>>>> --- a/Documentation/arch/x86/resctrl.rst
>>>> +++ b/Documentation/arch/x86/resctrl.rst
>>>> @@ -261,6 +261,16 @@ with the following files:
>>>> Available when ABMC feature is supported. The number of ABMC
>>>> counters
>>>> available for configuration.
>>>> +"mbm_assign":
>>>
>>> This name is not ideal but I am having trouble finding a better one
>>> ... I
>>> have
>>> seen you use "monitor mode" a couple of times (even in shortlog), so
>>> maybe
>>> that
>>> could be the start of a more generic name? "mbm_mode"?
>>
>> mbm_mode sounds good. Like this.
>>
>> $cat /sys/fs/resctrl/info/L3_MON/mbm_mode
>> [abmc]
>> legacy
>>
>> Keeping just "legacy" vs mbm_legacy.
>>
>
> Looks good to me. This sounds generic enough to build on.
Thanks
--
- Babu Moger
Powered by blists - more mailing lists