linux-kernel - Re: [PATCH v1 2/5] x86/sev: Move sev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <191d29ef-0539-4e23-b004-9ce7a9b63aa9@oracle.com>
Date: Fri, 21 Jun 2024 16:42:57 +0000
From: Liam Merwick <liam.merwick@...cle.com>
To: Michael Roth <michael.roth@....com>,
        "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>
CC: "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "pbonzini@...hat.com"
	<pbonzini@...hat.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "jroedel@...e.de" <jroedel@...e.de>,
        "thomas.lendacky@....com"
	<thomas.lendacky@....com>,
        "pgonda@...gle.com" <pgonda@...gle.com>,
        "ashish.kalra@....com" <ashish.kalra@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "pankaj.gupta@....com" <pankaj.gupta@....com>,
        Liam Merwick
	<liam.merwick@...cle.com>
Subject: Re: [PATCH v1 2/5] x86/sev: Move sev_guest.h into common SEV header

On 21/06/2024 14:40, Michael Roth wrote:
> sev_guest.h currently contains various definitions relating to the
> format of SNP_GUEST_REQUEST commands to SNP firmware. Currently only the
> sev-guest driver makes use of them, but when the KVM side of this is
> implemented there's a need to parse the SNP_GUEST_REQUEST header to
> determine whether additional information needs to be provided to the
> guest. Prepare for this by moving those definitions to a common header
> that's shared by host/guest code so that KVM can also make use of them.
> 
> Signed-off-by: Michael Roth <michael.roth@....com>

Reviewed-by: Liam Merwick <liam.merwick@...cle.com>


> ---
>   arch/x86/include/asm/sev.h              | 48 +++++++++++++++++++
>   drivers/virt/coco/sev-guest/sev-guest.c |  2 -
>   drivers/virt/coco/sev-guest/sev-guest.h | 63 -------------------------
>   3 files changed, 48 insertions(+), 65 deletions(-)
>   delete mode 100644 drivers/virt/coco/sev-guest/sev-guest.h
>