linux-kernel - Re: [PATCH v20 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9a00f59-eaa7-40a9-a118-66f87b11c118@web.de>
Date: Fri, 21 Jun 2024 19:05:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Tony Luck <tony.luck@...el.com>, x86@...nel.org,
 Babu Moger <babu.moger@....com>, Dave Martin <Dave.Martin@....com>,
 Drew Fustini <dfustini@...libre.com>, Fenghua Yu <fenghua.yu@...el.com>,
 James Morse <james.morse@....com>,
 Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
 Peter Newman <peternewman@...gle.com>,
 Reinette Chatre <reinette.chatre@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>, patches@...ts.linux.dev
Subject: Re: [PATCH v20 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection

…
> Add the missing definition of pr_fmt() to monitor.c. …

How do you think about to add the tag “Fixes” accordingly?


…
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
…
> +static __init int snc_get_config(void)
> +{
…
> +	cpus_read_lock();
> +	if (num_online_cpus() != num_present_cpus())
> +		pr_warn("Some CPUs offline, SNC detection may be incorrect\n");
> +	cpus_read_unlock();
…

Would you become interested to apply a statement like “guard(cpus_read_lock)();”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L133

Regards,
Markus